[TESTERS NEEDED] DS4: use hid_write instead of hid_write_control in bluetooth mode #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
hidsds
branch
2 times, most recently
from
7a261ed to
1a9a973
Compare
Megamouse
force-pushed
the
hidsds
branch
3 times, most recently
from
3da30fd to
1f9e337
Compare
Apparently this was only needed for Windows 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this was only needed for using the DS4 with bluetooth on Windows 7.
Since we don't use Windows 7 anymore, this should be obsolete and we can drop a commit on our hidapi fork.
Please test this with Windows 10/11 and a wireless DualShock 4 controller, using the DualShock 4 handler.